Skip to content

fix: remove the hard seam across the sky at the far scenery crest - #21

Merged
Attacktive merged 1 commit into
mainfrom
bugfix/horizon-glow-seam
Jul 27, 2026
Merged

fix: remove the hard seam across the sky at the far scenery crest#21
Attacktive merged 1 commit into
mainfrom
bugfix/horizon-glow-seam

Conversation

@Attacktive

Copy link
Copy Markdown
Owner

The bug

A straight horizontal line ran across the whole sky, well above the water — on the beach scene it sat at SEA_HORIZON - 0.078 (the sailboat's mast top), i.e. exactly at sceneryFarCrestY.

Two bands both terminated hard on that one row:

  • drawHorizonGlow ramped alpha 0 → 95 and then its rect just stopped at the crest, dropping back to 0 in a single pixel.
  • drawInterPlaneHaze started at alpha 55 on that same line, with nothing above it.

The fix

  • The glow fills past the crest — TileMode.CLAMP holds the end color and the silhouettes cover it — so the band never ends on a visible edge.
  • The haze ramps in from above the crest (0 → 55 → 0) instead of appearing at full strength on it.

Both scene planes still read the same; only the discontinuity is gone.

Verification

Rendered BEACH/DUSK at 1680×1050 on an emulator via a throwaway instrumentation harness that logs the sharpest row-to-row luminance steps in a clean sky column, at main and with this change:

y = 0.7724 (the seam) remaining top steps
before delta 18.0 0.845–0.851
after absent 0.845–0.853 only

What's left is the shoreline/reflection ramp at SEA_HORIZON, a genuine edge spread over ~10 rows rather than a 1px step. compileDebugKotlin and the unit tests pass.

🤖 Generated with Claude Code

The horizon glow ramped up to full alpha and then its rect simply ended at
sceneryFarCrestY, while the inter-plane haze started at alpha 55 on that same
line. Both edges landed on one row, drawing a straight line right across the
sky — on the beach scene at the sailboat mast top (SEA_HORIZON - 0.078).

The glow now fills past the crest (CLAMP holds the end color, and the
silhouettes cover it) and the haze ramps in from above the crest instead of
appearing at full strength on it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@Attacktive Attacktive self-assigned this Jul 27, 2026
@Attacktive Attacktive added the bug Something isn't working label Jul 27, 2026
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@Attacktive
Attacktive merged commit b0da8f7 into main Jul 27, 2026
5 of 6 checks passed
@Attacktive
Attacktive deleted the bugfix/horizon-glow-seam branch July 27, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant