fix(agent): reserve final step for response - #269
Open
mikemikimike wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an agent used every configured step for non-terminal tools, the loop emitted a synthetic max-steps reply without giving the model a chance to summarize completed work. This change reserves the final budgeted inference for
replyorfinish.Changes
Validation
npm test -- --run src/agent/agent-loop.test.ts src/agent/step-executor.test.ts(64 passed)npm run lint(passed)git diff --check(passed)The full test run reached 6,290 passing tests; 17 unrelated tests failed due to existing Windows/environment issues, including POSIX-only executable/path assumptions, temporary-directory teardown locks, a missing eval fixture, and platform-sensitive timing tests.