fix: handle Responses API event shape in OpenAI stream - #586
Open
ShreyaSev wants to merge 1 commit into
Open
Conversation
The OpenAI streamer assumed Chat Completions chunks (chunk.choices), but adalflow returns Responses API events, raising AttributeError on the first iteration. Fixes AsyncFuncAI#585"
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #585
Problem
respond_streamin the OpenAI streamer consumes the stream assumingChat Completions chunks, but adalflow returns Responses API events,
which have no
choicesattribute:File "/app/api/chat/_stream.py", line 169, in respond_stream chunk.choices AttributeError: 'ResponseCreatedEvent' object has no attribute 'choices'The stream raises on the first event, before yielding any text, so the
downstream structure parser then fails with a misleading
No valid <wiki_structure> XML found in response.Fix
Handle both event shapes in the loop, using
getattrso neitherattribute access can raise. Unknown event types (
response.created,response.completed) fall through both branches and are ignored.The Anthropic streamer in the same file is untouched — it already
reads its own provider's event shape correctly.
Testing
Built from this branch and generated a wiki successfully with the
OpenAI provider. Previously failed on every attempt.