Skip to content

fix: preserve full path in repo cache key for GitLab subgroup URLs (#438, #439) #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mvanhorn wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: preserve full path in repo cache key for GitLab subgroup URLs (#438, #439) #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cef74c3
fix: preserve full path in repo cache key for GitLab subgroup URLs
mvanhorn May 13, 2026
93fd6b1
refactor: collapse redundant repo-name path branches
mvanhorn Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 25 additions & 11 deletions api/data_pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,17 +769,31 @@ def reset_database(self):

def _extract_repo_name_from_url(self, repo_url_or_path: str, repo_type: str) -> str:
# Extract owner and repo name to create unique identifier
url_parts = repo_url_or_path.rstrip('/').split('/')

if repo_type in ["github", "gitlab", "bitbucket"] and len(url_parts) >= 5:
# GitHub URL format: https://github.com/owner/repo
# GitLab URL format: https://gitlab.com/owner/repo or https://gitlab.com/group/subgroup/repo
# Bitbucket URL format: https://bitbucket.org/owner/repo
owner = url_parts[-2]
repo = url_parts[-1].replace(".git", "")
repo_name = f"{owner}_{repo}"
repo_url_or_path = repo_url_or_path.strip().rstrip('/')

def strip_git_suffix(name: str) -> str:
return name[:-4] if name.endswith(".git") else name

if repo_type in ["github", "gitlab", "bitbucket"]:
parsed_url = urlparse(repo_url_or_path)
if parsed_url.scheme and parsed_url.netloc:
path_parts = [part for part in parsed_url.path.strip('/').split('/') if part]
else:
path = repo_url_or_path.split('?', 1)[0].split('#', 1)[0].strip('/')
path_parts = [part for part in path.split('/') if part]
if len(path_parts) >= 3:
host = path_parts[0].lower()
if "." in host or host == "localhost":
path_parts = path_parts[1:]

if path_parts:
path_parts[-1] = strip_git_suffix(path_parts[-1])
repo_name = "_".join(path_parts)
else:
repo_name = ""
else:
repo_name = url_parts[-1].replace(".git", "")
url_parts = repo_url_or_path.split('/')
repo_name = strip_git_suffix(url_parts[-1])
return repo_name

def _create_repo(self, repo_url_or_path: str, repo_type: str = None, access_token: str = None) -> None:
Expand Down Expand Up @@ -818,7 +832,7 @@ def _create_repo(self, repo_url_or_path: str, repo_type: str = None, access_toke
else:
logger.info(f"Repository already exists at {save_repo_dir}. Using existing repository.")
else: # local path
repo_name = os.path.basename(repo_url_or_path)
repo_name = self._extract_repo_name_from_url(repo_url_or_path, repo_type)
save_repo_dir = repo_url_or_path

save_db_file = os.path.join(root_path, "databases", f"{repo_name}.pkl")
Expand Down
2 changes: 1 addition & 1 deletion test/test_extract_repo_name.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def test_extract_repo_name_gitlab_urls(self):
# Test GitLab URL with subgroups
gitlab_subgroup = "https://gitlab.com/group/subgroup/repo"
result = self.db_manager._extract_repo_name_from_url(gitlab_subgroup, "gitlab")
assert result == "subgroup_repo"
assert result == "group_subgroup_repo"

print("✓ GitLab URL tests passed")

Expand Down