Skip to content

do not allow importing non-functional mods from astroneermods.space and its archives #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atenfyr merged 1 commit into from
Jul 16, 2026
Merged

do not allow importing non-functional mods from astroneermods.space and its archives #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions unreal_mod_manager/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ pub enum ModLoaderWarningKind {

MissingMetadata,
InvalidMetadata,
OutdatedSource,
InvalidModId,
InvalidModFileName,
InvalidVersion,
Expand Down Expand Up @@ -176,6 +177,12 @@ impl ModLoaderWarning {
mod_id: Some(mod_id),
}
}
pub fn outdated_source(mod_id: String) -> Self {
ModLoaderWarning {
kind: ModLoaderWarningKind::OutdatedSource,
mod_id: Some(mod_id),
}
}
pub fn invalid_mod_id(mod_id: String) -> Self {
ModLoaderWarning {
kind: ModLoaderWarningKind::InvalidModId,
Expand Down Expand Up @@ -259,6 +266,7 @@ impl fmt::Display for ModLoaderWarning {

ModLoaderWarningKind::MissingMetadata => format!("{mod_name}Missing metadata"),
ModLoaderWarningKind::InvalidMetadata => format!("{mod_name}Invalid metadata"),
ModLoaderWarningKind::OutdatedSource => format!("{mod_name}mod was obtained from an outdated source (e.g. astroneermods.space) and cannot be loaded in-game"),
ModLoaderWarningKind::InvalidModId => format!("{mod_name}Invalid mod ID"),
ModLoaderWarningKind::InvalidModFileName => {
format!("{mod_name}Invalid mod file name")
Expand Down
11 changes: 11 additions & 0 deletions unreal_mod_manager/src/mod_processing/pakfile_reading.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ use crate::{FileToProcess, ModLoaderAppData};

use super::verify::{self, MOD_FILENAME_REGEX};

const OUTDATED_SOURCE_URLS: &[&str] = &["astromod.space", "astroneermods.space", "atenfyr.com/ams-archive"];

#[derive(Debug)]
pub(crate) struct ReadData(String, Metadata);

Expand Down Expand Up @@ -56,6 +58,15 @@ pub(crate) fn read_pak_files(
return Err(ModLoaderWarning::invalid_mod_file_name(file_name));
}

// check that homepage doesn't contain outdated source URL
if let Some(ref homepage) = metadata.homepage {
let homepage_lower = homepage.to_lowercase();
if OUTDATED_SOURCE_URLS.iter().any(|banned| homepage_lower.contains(banned))
{
return Err(ModLoaderWarning::outdated_source(file_name));
}
}

let file_name_parts = MOD_FILENAME_REGEX
.captures(&file_name)
.ok_or_else(|| ModLoaderWarning::invalid_metadata(file_name.clone()))?;
Expand Down
Loading