fix: prevent RecursiveCharacterChunker overlap from exceeding chunk_size - #9922
Draft
lxfight wants to merge 1 commit into
Draft
fix: prevent RecursiveCharacterChunker overlap from exceeding chunk_size#9922lxfight wants to merge 1 commit into
lxfight wants to merge 1 commit into
Conversation
When a split triggered a flush, the chunker unconditionally built the next chunk as overlap_text + split without re-checking the combined length, so every flushed chunk could be up to chunk_size + overlap long (e.g. 562 chars with the default 512/50 config). _split_by_character already guarded against overlap >= chunk_size, but chunk() did not, so the two paths disagreed. Re-check the combined length after prepending the overlap and emit the overlap as a standalone chunk when it would exceed the limit; also apply the same parameter validation at chunk() entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9901
In
RecursiveCharacterChunker.chunk(), when a split triggered a flush, the next chunk was unconditionally built asoverlap_text + splitwithout re-checking the combined length againstchunk_size. Every flushed chunk could therefore be up tochunk_size + overlaplong (about 562 chars with the default 512/50 config), and a larger configuredoverlapmade the repeated overlap portion dominate the chunks, distorting embedding counts and retrieval quality.Meanwhile
_split_by_character()already rejectsoverlap >= chunk_size, so the two code paths disagreed on the same invariant.Modifications / 改动点
astrbot/core/knowledge_base/chunking/recursive.py:overlap + splitwould exceedchunk_size, emit the overlap as a standalone chunk (bounded byoverlap < chunk_size) and start the new chunk with the split only._split_by_characteratchunk()entry (chunk_size > 0,0 <= overlap < chunk_size) so both paths enforce the same invariant.tests/test_recursive_chunker.py: regression test proving no output chunk exceedschunk_size(fails on the old code with 110-char chunks), plus small-text, normal-text, and invalid-overlap cases.This is NOT a breaking change. / 这不是一个破坏性变更。
Screenshots or Test Results / 运行截图或测试结果
uv run ruff format/uv run ruff checkpass.chunk_sizeinstead ofchunk_size + overlap.Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。
🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
Summary by Sourcery
Ensure recursive character chunking respects configured size limits while validating overlap parameters consistently.
Bug Fixes:
Tests: