fix: remove All option from KB documents pagination to avoid page_size=-1 - #9918
Draft
lxfight wants to merge 1 commit into
Draft
fix: remove All option from KB documents pagination to avoid page_size=-1#9918lxfight wants to merge 1 commit into
lxfight wants to merge 1 commit into
Conversation
…e=-1 The documents table inherited Vuetify's default items-per-page options, which include -1 (displayed as All). The backend clamps page_size to at least 1, so selecting All returned a single document. Explicitly provide [10, 25, 50, 100], consistent with other pages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9907
In the WebUI knowledge base detail page, switching the documents table pagination to "All" sent
page_size=-1to the backend, wherelist_documentsclamps it withpage_size = max(page_size, 1). The response therefore contained only 1 document whiletotalwas correct.The
v-data-table-serverinDocumentsTab.vuedid not set:items-per-page-options, so it inherited Vuetify's default[10, 25, 50, 100, -1], where-1renders as "All".This PR follows option A suggested in the issue: explicitly provide
[10, 25, 50, 100](no "All" entry), consistent with other pages such asConversationPage.vue. The backend clamp is kept as a safety net.Modifications / 改动点
dashboard/src/views/knowledge-base/components/DocumentsTab.vue: add:items-per-page-options="[10, 25, 50, 100]"to the documentsv-data-table-server, removing the "All" option.This is NOT a breaking change. / 这不是一个破坏性变更。
Screenshots or Test Results / 运行截图或测试结果
npx vue-tsc --noEmitindashboard/passes (exit 0).page_sizeechoed correctly).Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。
🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
Summary by Sourcery
Bug Fixes: