Skip to content

fix: heal stale plugin sidebar entries when plugin page errors out #9917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lxfight wants to merge 2 commits into
base: master
Choose a base branch
from
+26 −3
Open

fix: heal stale plugin sidebar entries when plugin page errors out #9917

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83336a8
fix: heal stale plugin sidebar entries when plugin page errors out
lxfight Sep 2, 2026
bc2e556
fix: serialize plugin page loads with a sequence guard
lxfight Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions dashboard/src/views/PluginPagePage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { fetchWithAuth } from "@/api/http";
import { useModuleI18n } from "@/i18n/composables";
import { usePluginI18n } from "@/utils/pluginI18n";
import { useCustomizerStore } from "@/stores/customizer";
import { pluginSidebarState } from "@/composables/usePluginSidebarItems";

const BRIDGE_CHANNEL = "astrbot-plugin-page";

Expand Down Expand Up @@ -551,7 +552,13 @@ const handleIframeLoad = () => {
sendIframeContext();
};

let loadSequence = 0;

const loadPluginPage = async () => {
// Sequence guard: a stale response from a previous route must never
// mutate view state or the shared plugin sidebar state.
const requestSequence = ++loadSequence;
const requestedPluginName = pluginName.value;
loading.value = true;
errorMessage.value = "";
plugin.value = null;
Expand All @@ -561,7 +568,8 @@ const loadPluginPage = async () => {
cleanupSSEConnections();

try {
const detailResponse = await pluginApi.get(pluginName.value);
const detailResponse = await pluginApi.get(requestedPluginName);
if (requestSequence !== loadSequence) return;
if (detailResponse.data?.status === "error") {
throw new Error(
detailResponse.data.message || tm("messages.pluginPageLoadFailed"),
Expand All @@ -571,15 +579,27 @@ const loadPluginPage = async () => {
const pluginData = detailResponse.data?.data || null;
if (!pluginData) {
errorMessage.value = tm("messages.pluginNotFound");
// Heal the stale plugin entry in the shared sidebar state.
pluginSidebarState.plugins = pluginSidebarState.plugins.filter(
(p) => p.name !== requestedPluginName,
);
return;
}

if (!pluginData.activated) {
errorMessage.value = tm("messages.pluginDisabled");
// Heal the stale plugin entry in the shared sidebar state.
pluginSidebarState.plugins = pluginSidebarState.plugins.map((p) =>
p.name === requestedPluginName ? { ...p, activated: false } : p,
);
return;
}

const entryResponse = await pluginApi.page(pluginName.value, pageName.value);
const entryResponse = await pluginApi.page(
requestedPluginName,
pageName.value,
);
if (requestSequence !== loadSequence) return;
if (entryResponse.data?.status === "error") {
throw new Error(
entryResponse.data.message || tm("messages.pluginPageLoadFailed"),
Expand All @@ -602,12 +622,15 @@ const loadPluginPage = async () => {
contentUrl.searchParams.set('theme', themeParam.value);
iframeSrc.value = contentUrl.pathname + contentUrl.search + contentUrl.hash;
} catch (error) {
if (requestSequence !== loadSequence) return;
errorMessage.value =
error?.response?.data?.message ||
error?.message ||
tm("messages.pluginPageLoadFailed");
} finally {
loading.value = false;
if (requestSequence === loadSequence) {
loading.value = false;
}
}
};

Expand Down
Loading