fix: drop invalid 'All' page size option in knowledge base documents list - #9908
Open
xiaoxuan010 wants to merge 1 commit into
Open
fix: drop invalid 'All' page size option in knowledge base documents list#9908xiaoxuan010 wants to merge 1 commit into
xiaoxuan010 wants to merge 1 commit into
Conversation
…'All' value The v-data-table-server in DocumentsTab inherits Vuetify's default items-per-page-options [10, 25, 50, 100, -1], where -1 renders as 'All'. Selecting it sends page_size=-1, which the backend clamps to 1, so the document list shows only one item. Explicitly set :items-per-page-options to [10, 25, 50, 100] so the 'All' option is no longer offered, consistent with other pages such as ConversationPage. Closes AstrBotDevs#9907
xiaoxuan010
marked this pull request as ready for review
September 1, 2026 13:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / 变更动机
Fixes #9907.
The
v-data-table-serverinDocumentsTab.vuedid not set:items-per-page-options, so it inherited Vuetify's default[10, 25, 50, 100, -1]where-1renders as "All". Selecting "All" sendspage_size=-1toGET /api/v1/knowledge-bases/<kb_id>/documents, and the backend clamps it to1(page_size = max(page_size, 1)inKnowledgeBaseService.list_documents), so only 1 document is shown instead of all.This is a regression introduced by #9055, which switched the list to server-side pagination but never handled the "All" semantics.
Modifications / 改动点
dashboard/src/views/knowledge-base/components/DocumentsTab.vue: explicitly set:items-per-page-options="[10, 25, 50, 100]"onv-data-table-server, removing the invalid "All" option — consistent with existing pages such asConversationPage.vue.This is NOT a breaking change. / 这不是一个破坏性变更。
Verification Steps / 验证步骤
cd dashboard && npx vue-tsc --noEmit— type check passes (no output, no errors).cd dashboard && npx eslint src/views/knowledge-base/components/DocumentsTab.vue— the file has no lint errors (the repo-widenpm run lintfailures are pre-existing parsing errors in unrelated.mjs/.tsfiles).10 / 25 / 50 / 100, and the "All" option no longer appears.Screenshots or Test Results / 运行截图或测试结果
Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试,并已在上方提供了"验证步骤"和"运行截图"。
🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
Summary by Sourcery
Bug Fixes: