Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sync master-﹥dev #6397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
sync master-﹥dev #6397
Changes from all commits
18a99a2d41ccb76d055e8da520e53ccd70c20efaa5b0e10cf2f51916d87cf89420d82d64e0183d936bb0aa60467a3fa8a5dd89a4b2bbca8811c84096b3868b9909d7784e880aceb32dc7e3c32bbc3b5e5b795f8092c311965decfb2c49ac0e77500f3fbd16bFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new MiniMax provider preset sets
api_basetohttps://api.minimaxi.com/v1, which has an extraiin the hostname; users who rely on this default will fail to connect (DNS/connection errors) until they manually override it. This looks unintended because the MiniMax TTS preset in the same config uses theapi.minimax.chatdomain, so the chat preset should use a valid MiniMax endpoint as well.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://platform.minimaxi.com/docs/guides/quickstart-preparation
官方文档就是这个呀,没错吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (bug_risk): Narrow the exception handling when decoding the
extfield to avoid masking unrelated errors.Catching
Exceptionhere hides all parsing and programming errors, making real bugs hard to detect and debug. Limit this to the specific, expected failures (e.g.binascii.Error,json.JSONDecodeError,UnicodeDecodeError) so unexpected issues surface instead of always falling back to[表情].Suggested implementation:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
except Exception:is too broad and can hide unexpected errors. It's better to catch specific exceptions that you expect to occur, such asjson.JSONDecodeError,ValueError(for base64 decoding issues), orUnicodeDecodeError.Also, the
importstatements forbase64,json, andreshould be moved to the top of the file.References
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.