Skip to content

Use modern SCSS package and syntax#47

Draft
Lenni009 wants to merge 15 commits intoAssistantNMS:developfrom
Lenni009:scss-use
Draft

Use modern SCSS package and syntax#47
Lenni009 wants to merge 15 commits intoAssistantNMS:developfrom
Lenni009:scss-use

Conversation

@Lenni009
Copy link
Member

@Lenni009 Lenni009 commented May 19, 2023

closes #46

Khaoz-Topsy and others added 14 commits February 17, 2023 18:19
@Khaoz-Topsy
Merge pull request AssistantNMS#38 from AssistantNMS/develop
debb997 
🔖 0.28.0
@Khaoz-Topsy
🐛 Add trim to search
c6db3f0
@Khaoz-Topsy
Merge pull request AssistantNMS#39 from AssistantNMS/develop
a9b686a 
🔖 0.29.0
@Khaoz-Topsy
Merge pull request AssistantNMS#40 from AssistantNMS/develop
731b19c 
🔖 0.29.1
@Khaoz-Topsy
Merge pull request AssistantNMS#42 from AssistantNMS/develop
daf7dfc 
🔖 0.30.0
@Khaoz-Topsy
Merge pull request AssistantNMS#43 from AssistantNMS/develop
731deda 
🔖 0.31.0
@Khaoz-Topsy
Merge pull request AssistantNMS#44 from AssistantNMS/develop
b406090 
💚 Fix CI
@Khaoz-Topsy
Merge pull request AssistantNMS#45 from AssistantNMS/develop
e1bb1a2 
🔖 0.32.0
@Lenni009
use dart-sass
6f9cd1c
@Lenni009
use proper scss syntax
1bdc31a
@Lenni009
add object-fit to community search card img
2fba79a
@Lenni009
Merge branch 'main' of https://github.com/Lenni009/AssistantNMSWebApp
934792e
@Lenni009
fix package.json
39bb63d
@Lenni009
Merge pull request #1 from Lenni009/main
bf08ff4 
bring up to date
@Lenni009 Lenni009 changed the base branch from main to develop May 19, 2023 18:40
@Lenni009 Lenni009 changed the base branch from develop to main May 19, 2023 18:40
@Khaoz-Topsy Khaoz-Topsy marked this pull request as ready for review June 7, 2023 20:27
Khaoz-Topsy
Khaoz-Topsy reviewed Jun 7, 2023
View reviewed changes
src/scss/custom/_community.scss Outdated
img {
border-top-left-radius: $community-search-icon-border-radius;
border-top-left-radius: $community-search-icon-border-radius;
object-fit: contain;
Copy link
Member

@Khaoz-Topsy Khaoz-Topsy Jun 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this object-fit rule

@Khaoz-Topsy
Copy link
Member

Khaoz-Topsy commented Jun 7, 2023

Sorry it took so long for me to see this 😅. I just need that one rule removed that was added in this PR 😋. If you change this PR to be in develop, I will merge it very soon, else it needs to wait for future Kurt 😅

Also how did you get around the gitHooks that is supossed to enforce emoji use 😞

@Khaoz-Topsy
Copy link
Member

Khaoz-Topsy commented Jun 7, 2023

With the object-fit
image

Without
image

@Lenni009
Copy link
Member Author

Lenni009 commented Jun 7, 2023

So we want distorted images?

@Lenni009 Lenni009 changed the base branch from main to develop June 7, 2023 20:56
@Lenni009
Copy link
Member Author

Lenni009 commented Jun 7, 2023

AFAIK the PR also was meant as a draft, I did not yet manage to replace the @import statements with the proper @use ones. There's a lot going on in the CSS, especially with the SweetAlert code that wasn't written by you.

@Khaoz-Topsy
Copy link
Member

Khaoz-Topsy commented Jun 7, 2023

Yup, I want stretchy for all the non square images

Ah ok. I was impressed that there were so few file changes 😂

@Lenni009 Lenni009 marked this pull request as draft June 7, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Khaoz-Topsy Khaoz-Topsy Khaoz-Topsy left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Code Improvement]: Use @use instead of @import in scss files

2 participants

@Lenni009 @Khaoz-Topsy