[fix] Use non-detached Ray actor for SimpleStorageUnit#68
Merged
Conversation
Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
CLA Signature Pass0oshowero0, thanks for your pull request. All authors of the commits have signed the CLA. 👍 |
0oshowero0
changed the title
TransferQueueStorageUnitSimpleStorageUnit
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the SimpleStorage backend initialization to create SimpleStorageUnit Ray actors with the default (non-detached) lifetime, aligning actor lifecycle with the initializing Ray job and reducing the chance of orphaned storage processes lingering in the cluster.
Changes:
- Removed
lifetime="detached"fromSimpleStorageUnit.options(...)during SimpleStorage backend initialization.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0oshowero0
changed the title
SimpleStorageUnitSimpleStorageUnit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow PR #43 to use non-detached Ray actor for
SimpleStorageUnit