Skip to content

[Refactor] Move custom_meta to SampleMeta and custom_backend_meta to FieldMeta #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Evelynn-V wants to merge 4 commits into from
Closed

[Refactor] Move custom_meta to SampleMeta and custom_backend_meta to FieldMeta #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6156ed8
move custom_data to samplemeta and move custom_backend_meta to fieldmeta
Evelynn-V Feb 10, 2026
70edf78
move custom_data to samplemeta and move custom_backend_meta to fieldmeta
Evelynn-V Feb 10, 2026
f0bdd9a
fix test_kv_storage_manager
Evelynn-V Feb 10, 2026
f587529
fix test_kv_storage_manager
Evelynn-V Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions tests/test_kv_storage_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,18 @@ def test_get_shape_type_custom_backend_meta_list_with_custom_meta(test_data):
10: {"text": {"key7": "value7"}, "label": {"key8": "value8"}, "mask": {"key9": "value9"}},
}
metadata = test_data["metadata"]
metadata._custom_backend_meta.update(custom_backend_meta)

for global_idx, field_metas in custom_backend_meta.items():
template = SampleMeta(
partition_id="",
global_index=global_idx,
fields={
fname: FieldMeta(name=fname, dtype=None, shape=None, _custom_backend_meta=meta)
for fname, meta in field_metas.items()
},
custom_meta={},
)
next((s for s in metadata.samples if s.global_index == global_idx), None).union(template, validate=False)
Comment on lines +205 to +216

@dpj135 dpj135 Feb 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code appears multiple times; can it be refactored into a function?


shapes, dtypes, custom_backend_meta_list = KVStorageManager._get_shape_type_custom_backend_meta_list(metadata)

Expand Down Expand Up @@ -230,7 +241,18 @@ def test_get_shape_type_custom_backend_meta_list_with_partial_custom_meta(test_d
10: {"label": {"key2": "value2"}, "mask": {"key3": "value3"}}, # label and mask only
}
metadata = test_data["metadata"]
metadata._custom_backend_meta.update(custom_backend_meta)

for global_idx, field_metas in custom_backend_meta.items():
template = SampleMeta(
partition_id="",
global_index=global_idx,
fields={
fname: FieldMeta(name=fname, dtype=None, shape=None, _custom_backend_meta=meta)
for fname, meta in field_metas.items()
},
custom_meta={},
)
next((s for s in metadata.samples if s.global_index == global_idx), None).union(template, validate=False)

shapes, dtypes, custom_backend_meta_list = KVStorageManager._get_shape_type_custom_backend_meta_list(metadata)

Expand Down
Loading