Skip to content

[fix] Fix get_free_port in ipv6 environment#132

Merged
0oshowero0 merged 1 commit into
Ascend:mainfrom
0oshowero0:ipv6
Jul 1, 2026
Merged

[fix] Fix get_free_port in ipv6 environment#132
0oshowero0 merged 1 commit into
Ascend:mainfrom
0oshowero0:ipv6

Conversation

@0oshowero0

Copy link
Copy Markdown
Collaborator

As title

Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
Copilot AI review requested due to automatic review settings July 1, 2026 02:39
@ascend-robot

Copy link
Copy Markdown

CLA Signature Pass

0oshowero0, thanks for your pull request. All authors of the commits have signed the CLA. 👍

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes get_free_port to behave correctly when running in an IPv6 environment by binding an IPv6 socket to the IPv6 wildcard address.

Changes:

  • When detecting IPv6, bind the temporary socket to "::" instead of "" to ensure a valid IPv6 wildcard bind.
  • Preserve existing IPv4 behavior by continuing to bind to "" for IPv4 sockets.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@0oshowero0 0oshowero0 merged commit 489e3f1 into Ascend:main Jul 1, 2026
8 checks passed
@0oshowero0 0oshowero0 deleted the ipv6 branch July 1, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants