The water shelf shortens, and moves if you want it to - #128
Merged
suskozaver merged 1 commit intoSep 16, 2026
Merged
Conversation
Feature Request 24, the half that is about water. The half about tapping "It arrived" forty times is a different list and goes on its own. Sealed bottles of the same kind and the same size collapse into one row with a count. Not "water as one row", which is what was asked for and would be wrong: bottles differ by what they are, by size, and by whether they have been opened. 30 mL bacteriostatic and 10 mL saline stay two rows because they are two things you reach for at different moments. An open bottle always keeps its own row. Its beyond-use date runs from the day it was punctured, so a group would have to hide that date or invent one for bottles that do not share it. A bottle past its date keeps its own row too, for the reason the stock count already has written down: a filter that can hide something has to say so where it hides it. Grouping is a view. Every bottle stays its own record with its own dates, cost and history, and the row acts on one bottle rather than on all of them: opening a group opens the one the shelf would reach for next, which is the same arrangement groupSealedVials uses for vials. It also obeys the same setting, because somebody who wants forty vials on one row wants forty bottles on one row. Where the shelf sits is now a setting, default unchanged. It was asked for at the bottom, on the grounds that water is the least important thing on the page. True with forty bottles and false while reconstituting, when the bottle is the next thing you touch, so the fridge's owner decides. Three more pieces of English the translation pass missed, all in these rows and all in a file that imports useLang: the state badge printed b.state raw, the volume read "12 of 30 mL", and an unusable bottle said so in English in every language. Eight tests on shelfRows.
|
Someone is attempting to deploy a commit to the Arun's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Request 24, the half that is about water. The half about tapping "It arrived" forty times is a different list and goes on its own.
Grouping
Sealed bottles of the same kind and the same size collapse into one row with a count.
Not "water as one row", which is what was asked for and would be wrong. Bottles differ by what they are, by size, and by whether they have been opened. 30 mL bacteriostatic and 10 mL saline stay two rows, because they are two things you reach for at different moments.
An open bottle always keeps its own row: its beyond-use date runs from the day it was punctured, so a group would have to hide that date or invent one for bottles that do not share it. A bottle past its date keeps its own row too, for the reason the stock count already has written down: a filter that can hide something has to say so where it hides it.
Grouping is a view, and worth saying plainly because it is the thing people fear about grouping: every bottle stays its own record with its own dates, cost and history. The row acts on one bottle rather than on all of them, and the one it acts on is whichever the shelf would reach for next. That is the arrangement
groupSealedVialsalready uses on the other shelf, and it obeys the same setting, because somebody who wants forty vials on one row wants forty bottles on one row.Position
Where the shelf sits is a setting now, default unchanged.
It was asked for at the bottom, on the grounds that water is the least important thing on the page. That is true with forty bottles and false while reconstituting, when the bottle is the next thing you touch. Neither is wrong about their own fridge, so it is a setting rather than an argument.
Three more pieces of English
All in these rows, all in a file that imports
useLangand uses it everywhere else, which is exactly the blind spot noted in06-traps.mdafter the last two:b.stateraw, so a Slovenian install said "sealed"Checks
npx tsc --noEmit,npx next lint,npm testandTZ=America/New_York npm test: 63 files, 1651 tests, no warnings. Eight of them new, onshelfRows.