Feat/add micromerge#19
Merged
Merged
Conversation
ArtroxGabriel
force-pushed
the
feat/add-micromerge
branch
from
65a393e to
7af84ac
Compare
- Add XML documentation to IFileManager interface methods for clarity. - Refactor SequentialHeapFileManager to use consistent fileName keys for in-memory dictionaries and disk operations. - Improve file existence checks and error handling in CreateFileAsync and DeleteFileAsync. - Implement OpenFileAsync to load metadata and heap files from disk if not present in memory. - Make UnmarshalHeapMetadataFile asynchronous and update usages. - Ensure proper async disposal of file streams in CloseFileAsync. - Refactor helper methods for file creation, opening, and metadata updates to use consistent file paths and update in-memory state. - Set default value for HeapFileMetadata.FilePath.
- Refactored ExternalMergeSort and related methods to clarify memory constraints and buffer management. - Changed ExternalMergeSort to private and improved null checks. - Improved merge logic to use a buffer-constrained k-way merge with explicit run iterators and output buffering. - Simplified and clarified I/O operation counting.
Add detailed technical documentation (MicroMerge/README.md) describing architecture, memory constraints, algorithm phases, and extension guidelines for the MicroMerge sort-merge join implementation. Also add a user-facing README.md at the project root with installation instructions, usage examples, data schema, performance metrics, and contribution guidelines. Both documents emphasize the strict 4-page memory constraint and provide code snippets and troubleshooting tips.
Refactored Program.cs to robustly determine the base path for data and output directories, supporting execution from various working directories. Added informative console output for data and output locations. Updated output file writing to use the resolved output directory. Removed SubMerge project from solution and deleted user settings file. Also updated output CSV to reflect new join results.
ArtroxGabriel
force-pushed
the
feat/add-micromerge
branch
from
7af84ac to
e9691b8
Compare
ArtroxGabriel
force-pushed
the
feat/add-micromerge
branch
from
e9691b8 to
f72a7d2
Compare
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.