peekView colors are not consistently applied

[dimgrav]

Using:

• Pop!_OS 18.04
• VS Code v1.40.1

I have installed the theme using the built-in Extensions feature in VS Code.

I'm using the Pop Dark variation and I noticed that the peekView colors are not properly applied, which is not the case for the Light/Color variations:

By setting the peekViewTitle.background property in global settings.json, I am able to apply another color:

However, trying to override peekView.border has no effect.

[ArtisanByteCrafter]

Nice find! I'll look into this and get it updated soon

[ArtisanByteCrafter]

I should have this fixed now. I've got one other thing i want to look at then i can get an update published.

[ArtisanByteCrafter]

@dimgrav The update has been pushed - version 1.0.2 should now fix this, please update and let me know!

[dimgrav]

Thanks for the swift reply and action!

The peekView looks as per your screenshot now! However, the git diff border color is still not properly overridden (its value is still #11667d as shown in the second screenshot I posted previously).

I went through the docs myself to find if it's another component that's responsible for rendering the git diffs, but it doesn't look like it.

[ArtisanByteCrafter]

That's so odd. I'm my testing (screenshot I posted) it applies the peek border correctly. as a test, could you download the Insiders vscode and see if the peek border applies correctly there? Might be a sneaky setting somewhere in your vscode settings

[dimgrav]

Perhaps I wasn't clear enough.

File peek in peekView:

Git diff in peekView:

I'll do what you proposed and provide you with some feedback.

[ArtisanByteCrafter]

Ah gotcha, that might be different settings, I'll take a look too.