the localization for PELD by 1MLightyears · Pull Request #76 · ArtificialQualia/PyEveLiveDPS

1MLightyears · 2021-07-01T09:36:10Z

Sorry! My new job has been quite busy 😢 :
This pr is about a solution for localization of PELD, now PELD can be customed to display different languages in its GUI (if all things go well)
The solution is simple, and i placed the discription in lang/INSTRUCTIONS.md.
This pr includes many changes because most of the files need to import the new localization.py. Some other format changes are made auto by yapf with pylint.

ArtificialQualia · 2021-07-04T15:08:30Z

+            text=tr(
+                "To use a different character for fleet mode, choose a different\n"
+            ) + tr(" character in the 'Character...' menu on the main window"))


Should this be a single translation string?

yes, I think i used "global replace" to wrap the strings. If you need this i can fix it.

ArtificialQualia · 2021-07-04T15:10:28Z

        buttonFrame.grid(row="100", column="0", columnspan="10")
-        self.loginButton = tk.Button(buttonFrame, text="  Login  ", command=self.login)
+        self.loginButton = tk.Button(buttonFrame,
+                                     text="  Login  ",


This is my own i18n inexperience, but are commands like 'Login', 'Cancel', 'OK', universally understood?

Sorry! Looks like they are missed. Gotta check them all again! 😝

ArtificialQualia · 2021-07-04T15:11:15Z

                settings.lowCPUMode = True
-            self.mainWindow.topLabel.configure(text="Fleet Mode (" + self.characterName + ")")
+            self.mainWindow.topLabel.configure(
+                text="Fleet Mode ({0})".format(self.characterName))


Probably want to translate this as well

Sorry again! (x_x )

ArtificialQualia · 2021-07-04T15:15:35Z

    def convertNumberToStr(self, number):
        decimals = int(self.decimalPlaces)
-        formatString = '{:,.'+str(decimals)+'f}'
+        formatString = '{:,.' + str(decimals) + 'f}'


Note: We may want to i18n displaying numbers in the future as well. Not needed for this PR I think.

ArtificialQualia · 2021-07-04T15:29:46Z

+                    tr("Applying settings while in 'Low CPU Fleet Mode'") +
+                    tr(" will not apply until after you end Fleet Mode.\n\n") +


probably merge these translation strings too

ArtificialQualia · 2021-07-04T15:46:05Z

First: Thanks for the PR! It's a lot of work to go through this code that has architecture as more of an afterthought. I'm still going through the code changes here, but just some general thoughts/questions so far:

I think some of your path checking stuff in your localization.py file may break due to how PELD gets packaged. I think sys._MEIPASS will have to be used for path checking, but we will know for sure once we make a test build for this new code.

I'm torn on if \ns should be moved outside of translation dicts. On one hand, it would be less confusing to translators to have them out of the dicts, on the other hand different languages may have different spacing requirements. I'm leaning towards leaving them as you have them now.

I commented on a couple areas where I think multiple smaller translation strings should be merged into one larger translation string. This will help prevent mis-translations due to loss of critical context. There are probably other areas too, I haven't finished looking. Some areas certainly make sense to split up as they either contain whole thoughts/sentences or have reusable sections.

I'm not sure I can see an easy way for a user to change PELD's language looking at your code. I was envisioning something in the settings window, or perhaps auto-detection based on the OS language, but I don't see that in your PR. Nor do I see a language file for Chinese. It appears to me the PELD would just use whatever default language file is there.
Were you imagining having multiple builds/releases of PELD? One for each language supported? While that is possible, I think I'd like to have the same number of releases we have now and allow the use to switch between languages as they'd like (again, ideally defaulting to the OS language).

1MLightyears · 2021-07-07T09:17:29Z

Thank you for your review!

About the path checking, I think maybe i need to know more about sys._MEIPASS, since it failed in my python:AttributeError: module 'sys' has no attribute '_MEIPASS'
About \n, I'd like to suppose that the translator may not be so familiar about technological details, so maybe it's a better idea that all \n is left outside the strings, ensuring the translators to see one whole sentence at a time. If you also agree with this I can review and change them again.
About the interface of language part of PELD, I think PELD is a well-designed program and once am afraid that my add-ons might broke it 😞 . So I designed a localization which aims to do the smallest changes to PELD. I chose the change-file-for-different-languages solution based on an assumption that the user may not change their language often. If you think adding a new tab in Settings is a good idea, I'm also glad to implement that.
I deleted my Chinese version lang.jsonc by mistake! 😭 Have to translate again, sad story, will include that in the next commit

…dd sys.__MEIPASS processing stuff for consistency

1MLightyears · 2021-08-04T07:45:44Z

Hi
finally met my ddl of my work yesterday and get some time for PELD 😞 I'm not abandoning this!
I changed as many \n as I found out of tr() and update the lang.jsonc. I also re-translated a zh-CN version of lang.jsonc and included it in the commit.
The sys.__MEIPASS problem is also processed in localization.py, now it's covering both debug occasions (like python3 peld.py) and release occasions (like packaged by PyInstaller). I did a few test and it looks good, PELD seems to be localized pretty acceptable.
If you really need a GUI approach of modifing language when running (like add a page in settings) please feel free to let me know.
Sorry again (:з」∠)

ArtificialQualia · 2021-08-05T00:35:37Z

Thanks for the update! I'll give it a full look soon.

ArtificialQualia · 2021-08-16T12:52:03Z

The changes look good!

The only thing left I really want out of this is to have a single version of PELD for both Chinese and English users. As mentioned, ideally this would choose a default that makes sense based off the operating system language, and could be changed in the settings window to override that default.

If you don't want to do that, that's no problem, I can add the finishing touches on here. Just let me know what you'd like to do.

1MLightyears · 2021-09-02T07:12:03Z

Thank you for the comments!
I'll be having more free time in the following few weeks & I'll try to find an approach for placing language settings in Setting window.:smile:

add comments for localization.py & INSTRUCTIONS.md

5f9df1f

ArtificialQualia reviewed Jul 4, 2021

View reviewed changes

add a zh-CN version translation of PELD; fix misses in translation; a…

ce49be5

…dd sys.__MEIPASS processing stuff for consistency

ArtificialQualia mentioned this pull request Jun 5, 2022

PELD client/gui localization (Chinese) #66

Open

		tr("Applying settings while in 'Low CPU Fleet Mode'") +
		tr(" will not apply until after you end Fleet Mode.\n\n") +

Conversation

1MLightyears commented Jul 1, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ArtificialQualia commented Jul 4, 2021

Uh oh!

1MLightyears commented Jul 7, 2021

Uh oh!

1MLightyears commented Aug 4, 2021

Uh oh!

ArtificialQualia commented Aug 5, 2021

Uh oh!

ArtificialQualia commented Aug 16, 2021

Uh oh!

1MLightyears commented Sep 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants