Fix: Resolve path-related issues in reminder module - #42
Open
Shreyaav18 wants to merge 1 commit into
Open
Conversation
- Remove remindme() call at module import level - Fix jarvisremind.mp3 path to use absolute path - Add missing audio file to assets/media directory - Prevent FileNotFoundError on module import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed multiple path-related and import issues that were causing ModuleNotFoundError and FileNotFoundError.
Rationale for this change
Multiple import and path issues were causing the application to crash on startup:
reminder.pymodule was callingremindme()at import time, causing unexpected executionfeatures.search.prefix)features.utilitiesinstead offeatures.systemWhat changes are included in this PR?
core/Jarvismain.py:
from features.search.SearchNow import searchGoogle, searchyoutube, searchwikipediafrom features.system.battery import check_battery, battery(changed from utilities to system)features/utilities/reminder.py:
remindme()function call at module level (line 50)"jarvisremind.mp3"to absolute path usingos.path.join()Project structure alignment: Ensured all imports match the actual directory structure:
Are these changes tested?
Manual testing performed by running: