Skip to content

SimpleGenerativeModel: override to() to call it on base model#149

Open
ArneBinder wants to merge 1 commit into
mainfrom
simple_generative_model/override_to
Open

SimpleGenerativeModel: override to() to call it on base model#149
ArneBinder wants to merge 1 commit into
mainfrom
simple_generative_model/override_to

Conversation

@ArneBinder
Copy link
Copy Markdown
Owner

@ArneBinder ArneBinder commented Jan 24, 2025

Is this really necessary?

TODO:

  • check if this is not already handled by the lightning module

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 24, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.45%. Comparing base (6abf673) to head (5b36bcd).
⚠️ Report is 65 commits behind head on main.

Files with missing lines Patch % Lines
src/pie_modules/models/simple_generative.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
- Coverage   95.49%   95.45%   -0.04%     
==========================================
  Files          61       61              
  Lines        5173     5176       +3     
==========================================
+ Hits         4940     4941       +1     
- Misses        233      235       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants