Skip to content

282 fix bugs in nndataset and nnminmaxscaler after gnn merge pr 249 - #283

Open
fermingut wants to merge 3 commits into
241-improvements-in-gavi-examples-and-nn-modulefrom
282-fix-bugs-in-nndataset-and-nnminmaxscaler-after-gnn-merge-pr-249
Open

fermingut wants to merge 3 commits into
241-improvements-in-gavi-examples-and-nn-modulefrom
282-fix-bugs-in-nndataset-and-nnminmaxscaler-after-gnn-merge-pr-249

Conversation

@fermingut

Copy link
Copy Markdown
Collaborator

Closes #282

@fermingut
fermingut requested a review from ArnauMiro August 28, 2026 09:32
@fermingut fermingut self-assigned this Aug 28, 2026
@fermingut fermingut added the bug Something isn't working label Aug 28, 2026
@ArnauMiro

Copy link
Copy Markdown
Owner

@fermingut set to merge over #241 as I suspect we could be dealing with duplication

@fermingut
fermingut changed the base branch from develop to 241-improvements-in-gavi-examples-and-nn-module September 21, 2026 11:04
…82-fix-bugs-in-nndataset-and-nnminmaxscaler-after-gnn-merge-pr-249
@fermingut

Copy link
Copy Markdown
Collaborator Author

@ArnauMiro you were right, some changes were already being addressed in #284. I have solved the conflicts and we are ready to merge if everything else is fine

@ArnauMiro
ArnauMiro added this pull request to stack #287 September 21, 2026 16:23

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix bugs in NN.Dataset and NN.MinMaxScaler after GNN merge (PR #249)

2 participants