Skip to content

Complete migration from API v1 to v3 #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaiarmis merged 1 commit into from
Nov 4, 2025
Merged

Complete migration from API v1 to v3 #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion armis_sdk/core/armis_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
ARMIS_SCOPES = "ARMIS_SCOPES"
ARMIS_AUDIENCE = "ARMIS_AUDIENCE"
ARMIS_VENDOR_ID = "ARMIS_VENDOR_ID"
DEFAULT_PAGE_LENGTH = 1000
DEFAULT_PAGE_LENGTH = 100
try:
VERSION = importlib.metadata.version("armis_sdk")
except importlib.metadata.PackageNotFoundError:
Expand Down
1 change: 0 additions & 1 deletion docs/clients/NetworkEquipmentClient.md
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion docs/clients/SiteIntegrationsClient.md
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions tests/armis_sdk/clients/sites_client_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ async def test_get(httpx_mock: pytest_httpx.HTTPXMock):

async def test_hierarchy(httpx_mock: pytest_httpx.HTTPXMock):
httpx_mock.add_response(
url="https://api.armis.com/v3/settings/sites?limit=1000",
url="https://api.armis.com/v3/settings/sites?limit=100",
method="GET",
json={
"items": [
Expand Down Expand Up @@ -224,7 +224,7 @@ async def test_hierarchy(httpx_mock: pytest_httpx.HTTPXMock):
)
async def test_list_sites(from_response, expected, httpx_mock: pytest_httpx.HTTPXMock):
httpx_mock.add_response(
url="https://api.armis.com/v3/settings/sites?limit=1000",
url="https://api.armis.com/v3/settings/sites?limit=100",
method="GET",
json={"items": [from_response]},
)
Expand Down