I tried to add support for STM32G4#161
Open
aktronicsdotnet wants to merge 1 commit into
Open
Conversation
I'm sure I haven't done everything correctly but I tried my best to add support for STM32G4 series. Would be nice if @Arksine complete my attempt :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm sure I haven't done everything correctly but I tried my best to add support for STM32G4 series. Would be nice if @Arksine complete my attempt :)
There was a warning for flash.c:
src/stm32/flash.c: In function 'flash_get_page_size':
src/stm32/flash.c:40:1: warning: control reaches end of non-void function [-Wreturn-type]
}
adding CONFIG_MACH_STM32G4 to line 37 of file flash.c stopped the warning from popping up but I'm not sure if 128 * 1024 is correct for this series.
Additionally "Build Katapult deployment application (Do not build) --->" and "Application start offset ----" has no option in menuconfig, I'm not sure if other options are all correct neither.
@Arksine Thank you very much for considering adding support for G4 series 🙏