Repository navigation
Conversation
|
Thank you @johoja12 for following up on #645 so quickly. This PR sends every remote I checked it against master: the new Three small things, which I will apply on top when I merge:
No need for another round. Thanks again for the careful regression test. |
test: pin the double-quoted PATH literal of withRemoteTmuxPath() (dash 0.5.11+, bash and busybox pass the shell cases unquoted) docs: note in architecture-invariants that a new remote pane inherits the widened PATH from the creating tmux client Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
This landed in 1.45.0, thank you! It's the follow-up promised in #645. GitHub won't mark this PR as merged, because I reworded the commit subject before merging: |
Remote hosts with tmux installed in Homebrew or a per-user bin directory can fail Codeman's non-interactive SSH checks even though tmux works in their interactive shell. Fixing only history capture leaves those hosts blocked at linking or launch.
Add one
withRemoteTmuxPath()wrapper and apply it to every remote tmux entry point: availability checks, launch, attach, alive probes, discovery, history/screen capture, and cleanup. The entire exported PATH value is double-quoted, including inherited PATH, so home directories and PATH entries containing spaces work under dash. Existing SSH options, PTY flags, sockets, session targeting, CLI login-shell handling, and capture/backoff behavior are preserved.This is the separate PATH follow-up requested in #645. Tracks johoja12/Codeman#15.
Validation:
/bin/shand/bin/dash, with sparse PATH, a remote home and inherited PATH entry containing spaces, and offline SSH/tmux stubs. All 14 cases fail before the fix and pass afterward. Argv checks cover port, identity, jump host, proxy, custom SSH options and quoted session names.