Add DIFFSTARPOP_PBOUNDs namedtuple.#117
Merged
Merged
Conversation
aphearin
approved these changes
May 18, 2026
Contributor
aphearin
left a comment
aphearin
left a comment
There was a problem hiding this comment.
Looks good! Very clean simple change, nicely done. Maybe add one pytest enforcing that the default parameters are within the bounds? Otherwise this looks good to merge.
nvillanova
changed the title
Contributor
|
Nice job on this test. Merge whenever you are ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes a new namedtuple
BOUNDS_DIFFSTARPOP_PARAMSthat can be imported fromdiffstar.diffstarpop.It has the same structure as
DEFAULT_DIFFSTARPOP_PARAMS, but instead of storing the default scalar values, it stores tuples containing the lower and upper bounds for each parameter.