Implement rapid quenching into merging satellites#425
Conversation
… gd_phot_kernels.py and gd_phot_kernels_merging.py. This changes the API of gd_phot_kernels.py because now we need to know p_merge to compute no-merge photometry
|
The rapid quenching model brought in with this PR implements satellite quenching as a function of 
|
aphearin
changed the title
| ) | ||
| t_infall = t_obs - gyr_since_infall | ||
| logmp_infall = lgmu_infall + logmhost_infall | ||
| p_merge_smooth = merging_model.get_p_merge_from_merging_params( |
There was a problem hiding this comment.
Yep, I also faced this problem: needing p_merge before running _phot_kern_merging for the model change, in which fq changed as a function of p_merge. I went for a hacky workaround instead.
zaidikumail
left a comment
zaidikumail
left a comment
There was a problem hiding this comment.
This looks good to me @aphearin ! Thanks for rapidly implementing this. I will now run gradient descent with this branch.
2 participants
This PR implements a new rapid quenching feature into the
gd_phot_kernels.pyandgd_phot_kernels_merging.pymodules.