Repository navigation
Rover: prevent Dijkstra stalls with simple fence avoidance - #34495
Open
benhalverson wants to merge 3 commits into
Open
benhalverson wants to merge 3 commits into
benhalverson wants to merge 3 commits into
Conversation
benhalverson
marked this pull request as ready for review
September 24, 2026 10:41
Global Size Summary (Total Flash delta in bytes)Built from 01f6859 rebased onto 6743a33
|
benhalverson
force-pushed
the
fix/rover-dijkstra-simple-avoidance-30995
branch
from
October 16, 2026 00:07
b57acdb to
093e01e
Compare
Use at least twice the active horizontal fence margin when Rover combines Dijkstra with simple fence avoidance. Keep BendyRuler and stored parameters unchanged. Invalidate cached geometry when the margin changes and suppress polygon retries only for unchanged failed configurations.
Reproduce ArduPilot#30995 through Guided movement and fence telemetry. Cover both planners, margin overrides, runtime enabling, polygon and circle fences, and recovery after failed polygon generation.
The smaller circle admits a Dijkstra shortcut inside the simple avoidance stopping margin. Enlarge and reposition the fixture so the shortcut intersects the fence and the planned approach has sufficient clearance. Keep the arrival, stopping, breach and timeout assertions. The original fixture failed three north-facing SITL runs; the revised fixture passed seven runs across north-facing and default headings.
benhalverson
force-pushed
the
fix/rover-dijkstra-simple-avoidance-30995
branch
from
October 29, 2026 06:10
093e01e to
01f6859
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rover-fence.txt
Summary
Fixes #30995. When Rover combines Dijkstra with simple fence avoidance, use
max(OA_MARGIN_MAX, 2 × horizontal fence margin)and rebuild cached geometry when that margin changes.Classification & Testing
In the already-running MAVProxy command terminal:
After the fence finishes uploading and the EKF is ready:
Once it reports armed, command the destination 70 m east:
Expected: Rover drives around the rectangular exclusion fence and reaches the destination instead of stalling.
Check telemetry after arrival:
Expect
breach_status: 0,breach_count: 0, and groundspeed below0.3.When finished: