Preserve TLS write buffers across WebSocket retries - #44
Merged
Merged
Conversation
Appending video while SSL_write was pending could move its input buffer or change its length, disconnecting TLS viewers with a bad write retry error. Retain one stable TLS record until the write succeeds and rebuild all WebSocket users when its layout changes. Add real TLS 1.2 and TLS 1.3 backpressure regressions that queue additional video before the pending write completes.
TDB refuses duplicate handles in one process, so the threaded proxy simulation intermittently fails with EBUSY. Use a spawned process to match production, check its exit status and exact counter updates, and include both TLS retry regressions in the CI test list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Appending video while SSL_write was pending could move its input buffer or change its length, disconnecting TLS viewers with a bad write retry error. Retain one stable TLS record until the write succeeds and rebuild all WebSocket users when its layout changes.
Add real TLS 1.2 and TLS 1.3 backpressure regressions that queue additional video before the pending write completes.