Add editor MAVFTP transfers and filtering; fix console shutdown

[tridge]

Add enabled-by-default MAVFTP tickboxes to the mission and parameter editors. Read WPs and Write WPs use FTP when checked; Fetch all in the parameter editor also follows its checkbox. Parameter Write always uses PARAM_SET for edited values, without verification reads or a full refetch. FTP writes of changed parameters are deferred to a future PR.

Both editors show MAVFTP transfer status and completion results. Transfers start on the MAVProxy main loop, results from a previously selected vehicle are discarded, and mission downloads preserve edits made during the transfer. FTP uploads wait for the close acknowledgement before reporting success. CLI mission FTP uploads still require a filename.

Add a Non Default parameter filter using defaults reported by the selected vehicle. It combines with text search and refreshes as parameter values or defaults change. When defaults are unavailable, the editor explains how to fetch them.

Also fix console shutdown: after the close timeout, terminate and reap an unresponsive GUI child, escalating to kill if it ignores SIGTERM. Previously the child could keep Python waiting indefinitely after Ctrl-C.

Mission editor startup now passes only GUI queues and configuration to the child process, avoiding serialization of closed MAVProxy handles with Python 3.14 forkserver or spawn.

Validation:

• Mission startup, transfers, and geometry: 91 tests and 5 subtests passed. The startup regression reproduces the original closed-handle error before the fix on spawn and forkserver, and passes after it on spawn, forkserver, and fork.
• A real wx mission editor opened with an empty mission and closed cleanly using Python 3.14 forkserver.
• Editor and FTP suites: 77 tests and 11 subtests passed.
• Real wx checks confirmed Write uses PARAM_SET with either checkbox state and Fetch all follows the MAVFTP choice.
• Also checked mission checkbox layout, transfer success/failure feedback, preservation of edits during mission downloads, and Non Default filtering in real wx editors.
• Earlier shutdown validation covered a normal console and an unresponsive console child that ignores SIGTERM.
• No live vehicle testing.

[AP-Review]

Deprecated — see below for the updated review.

Previous review (2026-10-02)

Automated review note — AI-generated (Claude), validated against the live diff. Please sanity-check before acting.
Verdict: REQUEST CHANGES

Reviewed at head d96add8cae.
Full report: https://firmware.ardupilot.org/Tools/APReview/DevCallReviews/PRReviews/ardupilot/mavproxy/1766/1.html#prMAVProxy-1766

Thanks, the console shutdown fix and the editor MAVFTP support look good. The shutdown regression tests fail on the base and pass here, and the stricter mission download validation is a nice improvement.

One thing needs changing before merge. wp_ftp_upload now uploads the current loader when args is empty, but it is also the handler for wp ftpload, fence ftpload and rally ftpload. If the filename is forgotten, it no longer fails with an IndexError. It sends whatever is in the loader, possibly a zero-item file with options=0, and ArduPilot's finish_upload_mission() then clears the vehicle mission (fence and rally lists are replaced the same way). https://github.com/ArduPilot/MAVProxy/pull/1766/files#diff-67743c54e074d62f6942f6f146caf0b98e284d9b9c31d1115d94aee65a62e660R1122. Please keep the filename mandatory on the CLI path, for example with a usage error when args is empty and no callback is given, or give the editor its own entry point.

Smaller items, none blocking:

• FTP parameter writes mark every submitted value as written once the put completes. ArduPilot's param_upload_parse skips read-only, internal-use or locked parameters and still succeeds, whereas the MAVLink path returns the real value. A readback before clearing pending changes would fix it: https://github.com/ArduPilot/MAVProxy/pull/1766/files#diff-68655e9162d7f0884145944097120f52a93e1768f77ad8ada2a26badcf2b262fR955.
• Mission FTP success is reported before the TerminateSession reply, so a mission rejected at close() (for example a bad DO_JUMP target) is shown as SYNCED. This is older mavproxy_ftp.py behaviour, but waiting for the close ACK would make the new status honest: https://github.com/ArduPilot/MAVProxy/pull/1766/files#diff-0ab3018f1d2d9bd9bfddf3d8f1b1eb69430582a485e5e70a4c2abce261ae73e7R230.
• Editor transfers call into the FTP manager from the editor event threads without a lock. A forced schedule produced duplicate session ids, so starting them from the main thread would be safer: https://github.com/ArduPilot/MAVProxy/pull/1766/files#diff-0ab3018f1d2d9bd9bfddf3d8f1b1eb69430582a485e5e70a4c2abce261ae73e7R225.
• The parameter editor's MAVFTP checkbox could be initialised from param_ftp: https://github.com/ArduPilot/MAVProxy/pull/1766/files#diff-fc7b9c37bea3826b33fb448536e9646e43e33c8e39be3fe7b06bdc5b4382505dR43.
• A param fetch that completes after a vehicle switch is shown with the newly selected vehicle's defaults and name: https://github.com/ArduPilot/MAVProxy/pull/1766/files#diff-0ab83ea322003df1a970173025fa9b450bf0b84cb54dbcba7253dfcafc81162bR384.
• An FTP mission read overwrites grid edits made while it was running and leaves the label at MODIFIED: https://github.com/ArduPilot/MAVProxy/pull/1766/files#diff-0ab3018f1d2d9bd9bfddf3d8f1b1eb69430582a485e5e70a4c2abce261ae73e7R206.

[AP-Review]

Automated review note — AI-generated (Claude), validated against the live diff. Please sanity-check before acting.
Verdict: COMMENT

Reviewed at head 50b68069cc.
Full report: https://firmware.ardupilot.org/Tools/APReview/DevCallReviews/PRReviews/ardupilot/mavproxy/1766/2.html#prMAVProxy-1766

Thanks for the update. This follow-up covers commit 50b6806; the PR has since moved to 996623a, which I haven't reviewed. The earlier blocker is fixed: a bare wp/fence/rally ftpload now prints a usage message, and the editor uses its own ftp_upload. Five of the six smaller items are resolved too, and the socket-free PR tests pass at 50b6806.

Remaining suggestions, none blocking:

• The parameter editor's MAVFTP checkbox still starts ticked regardless of param_ftp. Passing the setting to child_task would match param fetch: https://github.com/ArduPilot/MAVProxy/pull/1766/files#diff-fc7b9c37bea3826b33fb448536e9646e43e33c8e39be3fe7b06bdc5b4382505dR43
• The editor's FTP mission Write assembles rows in the shared wp loader, so a CLI mission download finishing mid-write can produce a mixed upload that is then shown as SYNCED. The MAVLink path already had this exposure, but building the upload in a private loader would close it: https://github.com/ArduPilot/MAVProxy/pull/1766/files#diff-0ab3018f1d2d9bd9bfddf3d8f1b1eb69430582a485e5e70a4c2abce261ae73e7R167
• After an FTP Fetch all, staged edits stay pending while the cell shows the fetched value, so the next Write sends a value the grid no longer shows. MAVLink Fetch drops them, and doing the same here would be consistent: https://github.com/ArduPilot/MAVProxy/pull/1766/files#diff-0ab83ea322003df1a970173025fa9b450bf0b84cb54dbcba7253dfcafc81162bR413
• On a vehicle switch only the defaults refresh, so the Non Default filter compares the previous vehicle's values with the new vehicle's defaults: https://github.com/ArduPilot/MAVProxy/pull/1766/files#diff-0ab83ea322003df1a970173025fa9b450bf0b84cb54dbcba7253dfcafc81162bR187

SITL, real hardware and a displayed GUI were not exercised.

Head moved during review: observed 996623a598ed6ba7324c74be1162358cd535f10b. This review covers only 50b68069cc58b87357621655027a6beefce90373; followup eligible.