Conversation
Map vehicle boot clocks into local time and match vehicle yaw to gimbal feedback so transport jitter does not mix samples of different ages. Derive stationary ROI line-of-sight rates directly from position and velocity, avoiding quantisation from finite differences of rounded coordinates, and stop prediction when telemetry is stale.
Preserve yaw history when corrected sample times coincide, allow ATTITUDE fallback at prediction expiry, and retain vertical-pitch metadata without using an undefined yaw rate for control. Carry measured gimbal yaw rate into video metadata so prediction avoids differentiating quantised angles, with regression tests and documentation for both changes.
Contributor
Author
|
replaced by #31 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vehicle and gimbal telemetry can describe different instants, producing yaw-rate ripple during ROI tracking. Finite differences of rounded positions and gimbal angles also introduce noise into control feed-forward and SITL video prediction.
Map vehicle boot timestamps into camera monotonic time using the AP_RTC minimum-delay estimator, and interpolate vehicle yaw/rate at the gimbal feedback timestamp. Derive stationary ROI line-of-sight rates analytically from GLOBAL_POSITION_INT position and NED velocity, and carry measured gimbal yaw rate through video metadata for prediction. Predictions stop after 250 ms of stale data; ATTITUDE fallback becomes eligible at that limit. Legacy metadata without measured rates remains supported.
Includes regression coverage for timestamp wrapping, restarts, reordered/buffered samples, fallback, singular geometry and quantised gimbal feedback, plus camera and SITL documentation updates.
Validation:
The clock estimator cannot remove fixed one-way latency; MT11 feedback is still timestamped on receipt. Real motor-response ripple can remain.