Core: Allow configuring logfile retention #5795
Open
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
Emerassi
approved these changes
Dec 26, 2025
Contributor
Emerassi
left a comment
Emerassi
left a comment
There was a problem hiding this comment.
This addition seems sensible and I see no problems with the code.
silasary
approved these changes
Dec 27, 2025
Collaborator
silasary
left a comment
silasary
left a comment
There was a problem hiding this comment.
Simple enough change, works as intended.
silasary
added
waiting-on: core-review
EmilyV99
approved these changes
Dec 27, 2025
Contributor
EmilyV99
left a comment
EmilyV99
left a comment
There was a problem hiding this comment.
Seems like a simple enough change. Code looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adds the ability to configure how many days Archipelago logfiles are retained before automatic cleanup. Also allows disabling automatic cleanup by setting the
log_retention_daysvalue to 0.How was this tested?
Ran pytest in general and utils test folders.
Generated local host.yaml and verified debug log messages with different values for
log_retention_days.