WebHost: Fix world sorting in /tutorial/

[remyjette]

What is this fixing or adding?

While there is an attempt to title_sorted the worlds, it's done on the wrong dict. tutorials is never iterated; it's only accessed by index (via tutorials[world_name].items()) thus its order does not matter. The dict that needs to be sorted is worlds, as that's what's iterated (via % for world_name, world_type in worlds.items() %})

As a result, on main the worlds on the tutorial page are not title_sorted like they are in the Supported Games list (notice how on https://archipelago.gg/tutorial/ "A Hat in Time" and "A Link to the Past" are both sorted with the As rather than with the Hs and Ls respectively).

In addition, worlds/__init__.py loads all world sources first, then all apworlds. AutoWorldRegister.world_types is a dict which as of Python 3.7 maintains insertion order. If a custom WebHost is adding additional worlds via custom_worlds, those will all be after any worlds from the worlds/ folder. Since worlds is never sorted, when rendering /tutorial/ on the WebHost, all custom worlds end up coming after all worlds in worlds/:

How was this tested?

Confirmed locally that "Archipelago" is still first:

And that "A Hat in Time" is now sorted with the Hs:

Put pokemon_frlg.apworld in custom_worlds. Loaded the webhost before the change, see screenshot above. Loaded after the change:

[silasary]

This is such a subtle change, but can confirm it does work.

[PoryGone]

I assume this is also fixed by this PR:

[remyjette]

Yep, I have this on my webhost

[nicholassaylor]

LGTM