KH2: converting the client to use Lua Socket instead of pymem with some other changes #5783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: qwint <qwint.42@gmail.com>
…ike/Archipelago into kh2-optimize-client
check if the infobar is active before setting
…o incorretly loading seed_save
…lues to the lua for it to handle it all on its side. whenever the sold items chagnes lua sends teh values back to the client to save. Update MessageTypes emun
fix sending keybalde abilities to sora
…onstant Update logger.info that use a line number to the function instead so it stays correct Bring back SeedSave to store sold equipment since the lua would lose them on refresh and also bring back form levels into it remove , in MessageTypes enum, update port to not conflict with DDD implementation, update to follow Style Guide Remove uneeded f.close() and fix any keyblade ability exiting ReceivedItems entirely(replaced return with continue)
…ed the icon and preview code to base off of. remove commented out locations that no longer exist. fixed two typos in LocationName
… pass the connection arguments. remove client.py in the main folder and rename clientstuff folder to client. handle client.py stuff in init
and some windows errors fixed that happen because of the linux fixes
…ted message can appear again (on successful connection)
github-actions
bot
added
the
waiting-on: peer-review
Collaborator
|
It'd probably be best to keep those open if they're still relevant on their own. It's easier to review smaller things on their own instead of being bundled into a larger change, and those already had maintainer approval as well (albeit they were admittedly still waiting a while). |
use CHUNK_SIZE for determining if len > in case i cahnge it in the future to only need to change the varaible and not variable and number also change >= to > since 30 byte long messages are fine i want to split when above 30 bytes
…t it was important for sending the locations remove more no longer used variables rename sora_form_levels to just sora_level hopefully made kh2_watcher more efficient and didnt make it worse
keep a set of chests already sent across lua socket to not resend duplicate entries
…f kh2connection confirmed to not use the event twice in a row, clear checked_chests on disconnect
receive if final xemns defeated over lua socket since its not an actual location that info is needed from the lua
…n (it wasnt showin on source i guess the requirements arent quite the same or something) Try to prevent a bad http request from causing the KH2 client to throw an error and register a bad slotname as cached slot Update MessageType enums one last time
Format the archipelago.json back to how Jared had it and bump the world_version Make some options description more descriptive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
This removes pymem from the client and converts it to using Lua Socket. In doing so a decent bit of client code has been removed. This is based off of jareds deathlink branch so it should be merged after #5206
This allows the client to run natively on linux and no longer need to be run a specific way to let the client interact with the game. (part of that being needing the windows version of AP installed on linux)
Also has my two other PRs #4577 and #4588 so I closed them.
Capping hits to level up valor form (if not set to vanilla level requirements) to (90 + formLevel * 5) which is a max of 120 to reach level 7.
Adds an option to KH2 to choose whether you want to skip the AS fight of 5 bosses to fight the data version instead. Allows a choice in the yaml to make the fights the harder version for the checks or the easier version.
Also updates Disney Castle Key with the rename base KH2 Rando did naming it Royal Summons instead.
Remove backwards compatibility thats been around for multiple versions since it would require much more Lua additions.
Rename slot data to be more correct eg: KeybladeAbilities was all SoraAbilities not just his weapons.
Rename ClientStuff folder to Client and add the ability to launch the KH2 Client when clicking your slot on the website. Also remove old Client.py in the base of kh2 entirely with this change.
Fix a couple typos in itemnames
update setup guide as there is now a full version self contained on KH2Rando.com and that is the preferred site for it now.
At jareds request
Remove ansem reports from the pool since they do nothing
comment out no exp since you always start with it via the mod
remove donalds name before his limit names to match goofy
How was this tested?
Multiple APs with various settings on both windows and linux to confirm everything still works and it also now natively works on windows.
If this makes graphical changes, please attach screenshots.