fix: enable vision routing fallback in Path A describe - #65
Open
codysk wants to merge 1 commit into
Open
Conversation
When the main model has vision:true (Path A), describe calls only used [llmConfig] and ignored the vision routing chain, so a main-model outage (e.g. kimi-k3 503) left vision describe dead with no fallback — placeholders instead of trying qwen3.7-plus etc. Path A now uses dedupConfigs([llmConfig, ...visionLlmConfigs]): main model first, then the vision routing chain deduped by name (fallback to model@baseUrl). Also pass the full vision chain (not [0]) from main.ts initializeCodeActExecutor to code-act-executor, widening its visionLlmConfig type to LLMConfig[].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the main model has
vision:true(Path A), describe calls only used[llmConfig]and ignored the vision routing chain, so a main-model outage (e.g. kimi-k3 503) left vision describe dead with no fallback — placeholders instead of trying qwen3.7-plus etc.Path A now uses
dedupConfigs([llmConfig, ...visionLlmConfigs]): main model first, then the vision routing chain deduped by name (fallback tomodel@baseUrlfingerprint). Also pass the full vision chain (not[0]) frommain.ts initializeCodeActExecutortocode-act-executor, widening itsvisionLlmConfigtype toLLMConfig[].This makes Path A describe consistent with the vision routing fallback already used by
vision.see(host-call-handler) and Path B.