Repository navigation
Fix SFDR at masked spectrum boundaries - #101
Merged
Merged
Conversation
Compensate integrated spur lobes when signal/DC masks or the analysis boundary hide side bins, and keep MATLAB auto sideBin from collapsing below the selected window's coherent main-lobe width.\n\nFixes #100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This keeps the integrated-lobe SFDR convention established by #64/#65/#67, removes the 0.79–1.76 dB optimistic boundary bias, and prevents a noise-free Hann record from collapsing to
sideBin=0.Fixes #100.
Evidence
After: all six cases report 80.00 dBc, including public defaults with automatic
side_bin.assumed_sig_pwr_dbfsbehavior.901 passed, 11 deselected, 1 xfailed; integration validation:34 passed.Merge Danger
Door: Two-way
The change is isolated and can be reverted without data migration or API rollback.
Blast Radius: Spectrum metrics
Only SFDR cases whose spur lobe touches the signal/DC/analysis boundary change; MATLAB automatic side-bin selection also changes for noise-free windowed tones.