Skip to content

IH-1226 : Updated Instrument and InstrumentManifest#115

Closed
nitinpalewar-hach wants to merge 2 commits intomainfrom
IH-1226
Closed

IH-1226 : Updated Instrument and InstrumentManifest#115
nitinpalewar-hach wants to merge 2 commits intomainfrom
IH-1226

Conversation

@nitinpalewar-hach
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@MatthewDeRose-AI MatthewDeRose-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I didn't catch this until today. I think there's some confusion about how the nuget package publishing works. This is an example of a combo of PRs for the ONE.Interfaces.CSharp and ProtocolBuffer repos: https://github.com/AquaticInformatics/ONE.Interfaces.CSharp/pull/109/changes and https://github.com/AquaticInformatics/ONE.Interfaces.ProtocolBuffers/pull/117/changes. If you see in the ONE.Interfaces.CSharp PR we also have the associated changes from the submodule ProtocolBuffers. On my local I built the ProtocolBuffer repo as a submodule of the ONE.Interfaces.CSharp repo (reference: https://git-scm.com/book/en/v2/Git-Tools-Submodules) so that when we merge the ONE.Interfaces.CSharp changes into main the protocol buffer changes are included in the nuget package. I'll see if I can find some SW documentation about this. @AQI-DanG has a teams chat post about this

Image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the number of changes here it seems like this is not pointed at the right commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants