IH-1226 : Updated Instrument and InstrumentManifest#115
IH-1226 : Updated Instrument and InstrumentManifest#115nitinpalewar-hach wants to merge 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Sorry for the delay, I didn't catch this until today. I think there's some confusion about how the nuget package publishing works. This is an example of a combo of PRs for the ONE.Interfaces.CSharp and ProtocolBuffer repos: https://github.com/AquaticInformatics/ONE.Interfaces.CSharp/pull/109/changes and https://github.com/AquaticInformatics/ONE.Interfaces.ProtocolBuffers/pull/117/changes. If you see in the ONE.Interfaces.CSharp PR we also have the associated changes from the submodule ProtocolBuffers. On my local I built the ProtocolBuffer repo as a submodule of the ONE.Interfaces.CSharp repo (reference: https://git-scm.com/book/en/v2/Git-Tools-Submodules) so that when we merge the ONE.Interfaces.CSharp changes into main the protocol buffer changes are included in the nuget package. I'll see if I can find some SW documentation about this. @AQI-DanG has a teams chat post about this
There was a problem hiding this comment.
Based on the number of changes here it seems like this is not pointed at the right commit
No description provided.