feat: adopt shared @aprovan/ configs from npm#2
Merged
Conversation
JacobSampson
force-pushed
the
agent/engineer/164b4087
branch
from
e1ee467 to
158e0b6
Compare
- Add root tsconfig extending @aprovan/tsconfig/base.json - Migrate ESLint v8 to v9 flat config extending @aprovan/eslint-config/base - Add @aprovan/prettier-config, bump Prettier ^2→^3 - Remove old eslint v8 plugins - Bump pnpm to 9.15.9 - Add lint/typecheck/format scripts - Fix import ordering and type imports - Fix unused variables and dead imports - Fix async promise executor - Fix type errors in core tests - Remove pnpm/action-setup version in workflows
JacobSampson
force-pushed
the
agent/engineer/164b4087
branch
from
158e0b6 to
0dde8cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts shared @aprovan/ config packages published on npm.
Changes
tsconfig.jsonextending@aprovan/tsconfig/base.json.eslintrc.json(ESLint 8) to flateslint.config.mjs(ESLint 9) extending@aprovan/eslint-config/base.prettierrcnow references@aprovan/prettier-config, bumped Prettier ^2 → ^3lint,lint:fix,format,typecheckscripts and turbo taskValidation
pnpm lint: 0 errors (25 warnings fromexplicit-member-accessibilityset towarn)pnpm typecheck: 36 errors (down from 41 pre-existing — all pre-existing, none introduced)pnpm format: passesCloses APR-102