192 bug excluded inputs regex argument is not respected#196
Merged
averissimo merged 19 commits intoJul 14, 2025
Conversation
1 task
This reverts commit 9400096.
Contributor
|
Thanks for the fix, looks good 🤩 Can you look at #201 that extracts the function and tests it? (so this does not ever happen again) |
…ts_regex-argument-is-not-respected-averissimo * origin/main: Fixes concurrent log file write bug (#200)
…rgument-is-not-respected-averissimo Extract merge of excluded regular expression
averissimo
deleted the
192-bug-excluded_inputs_regex-argument-is-not-respected
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #192
Changes description
Remove string escaping to allow regex to actually work.
Do be honest, I don't understand why the regex is escaped in the first place.
I checked several levels of git-blame, and some form of string escaping was first introduced here by @arunkodati77.
@averissimo maybe you have some context as to why this change was needed? The way I see it today, is that a regex string should be escaped in case you don't want it to be parsed as a regex, not vice versa.
Definition of done
NEWS.mdfile has been updatedx.y.z.90XX)Development)