Skip to content

Refactor box base XPath#180

Open
radbasa wants to merge 4 commits into
177-unique-attached-object-namesfrom
177a-refactor_xml_base_path
Open

Refactor box base XPath#180
radbasa wants to merge 4 commits into
177-unique-attached-object-namesfrom
177a-refactor_xml_base_path

Conversation

@radbasa

@radbasa radbasa commented Jul 17, 2025

Copy link
Copy Markdown
Collaborator

Refer to PR #179

Separate pull request to isolate changes.

Description

  • The detection for / to identify modules, and no / to identify packages have been moved to the functions.
  • box_module_base_path() and box_package_base_path() are now replaced by the common box_base_xpath().
  • All functions that refer to box_*_base_path() have been modified to use box_base_xpath().
  • Legacy linters with hard-coded box base xpath have also been modified to reference box_base_xpath().
  • New unit test cases added for box_unique_names_linter.
  • Unit tests for all other linters are unmodified.
  • Regression tests pass.

Definition of Done

  • The change is thoroughly documented.
  • The CI passes (R CMD check, linter, unit tests, spelling).
  • Any generated files have been updated (e.g. .Rd files with roxygen2::roxygenise())

@codecov

codecov Bot commented Jul 17, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.10%. Comparing base (3231b1b) to head (d0da497).

Additional details and impacted files
@@                        Coverage Diff                        @@
##           177-unique-attached-object-names     #180   +/-   ##
=================================================================
  Coverage                             97.10%   97.10%           
=================================================================
  Files                                    25       25           
  Lines                                  1242     1243    +1     
=================================================================
+ Hits                                   1206     1207    +1     
  Misses                                   36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@radbasa radbasa changed the title 177a refactor xml base path Refactor box base XPath Jul 17, 2025
@radbasa radbasa changed the base branch from main to 177-unique-attached-object-names July 17, 2025 07:46
@radbasa radbasa requested a review from jakubnowicki July 17, 2025 07:47
@radbasa radbasa marked this pull request as ready for review July 17, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant