build: prefer llama.cpp-mainline over sibling llama.cpp#2
Open
smanaton wants to merge 2 commits into
Open
Conversation
The Apothic-AI fork (often checked out as a sibling llama.cpp) trails upstream ggml and produces NaN logits on Q1_0 models. Prefer a llama.cpp-mainline checkout when present so accidental builds against the fork fail less silently. WWAMA_LLAMA_CPP_DIR still overrides entirely.
Copilot stopped reviewing on behalf of
smanaton due to an error
July 19, 2026 18:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When auto-detecting llama.cpp, prefer a sibling/checkout named
llama.cpp-mainlineoverllama.cpp.Some forks lag upstream ggml and have produced non-finite (NaN) logits on Q1_0 models. An explicit mainline directory name makes the intended tree obvious.
WWAMA_LLAMA_CPP_DIRstill overrides entirely.Dependency
On Windows you still need the MSVC/CUDA build PR (or equivalent) to link successfully. Suggested merge order: windows-fixes first, then this.
Test plan
cargo buildwithoutWWAMA_LLAMA_CPP_DIRselectedllama.cpp-mainlinewhen present.Notes
Fork staging: smanaton#2