Windows (MSVC) build docs and JSON inspect fix#1
Open
smanaton wants to merge 3 commits into
Open
Conversation
serde_json cannot serialize maps with tuple keys, so every --json inspect run failed with "key must be a string" after a full model load. Emit the tensor list instead; each TensorInfo already carries layer and projection. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
CMake >= 4.3 for the Visual Studio 18 generator, and Ninja + vcvars64 for CUDA builds when VS is newer than the CUDA toolkit's VS integration. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot stopped reviewing on behalf of
smanaton due to an error
July 17, 2026 18:07
Guards the serde_json tuple-key fix for --json inspect.
smanaton
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows-oriented fixes that make Miyagi usable on MSVC toolchains and fix machine-readable inspect output.
--json inspect:ArchitectureMap.tensorsused tuple map keys, whichserde_jsoncannot serialize (key must be a string). Emit tensors as a JSON sequence; eachTensorInfoalready carries layer + projection.tensorsis an array.Test plan
--json inspectsucceeds after the serialization change (Windows).architecture_map_json_serializes_tensors_as_array.Notes
Fork staging: smanaton#1