Default the M-1 to WLED 16.0.1 - #25
Merged
Merged
Conversation
The M-1 page opened on WLED-MM 14.5.1 (Rev6). Make WLED 16.0.1 (Rev6 only) the default by moving it to the first key of firmware.stable, which is what device.js picks on load. Rev4 hardware is not covered by 16.0.1, so Rev4 owners now have to switch to the "WLED-MM 14.5.1 (Rev4)" variant instead of landing on a working default. Side effect of the reorder, both already-built behavior, no code change: the page now loads with the "Classic installer" link hidden (WLED-M1 has no installer page, installers.stable maps that variant to null) and the header GitHub link pointing at WLED-M1. Both come back on a 14.5.1 variant. Two tests guarded themselves with test.skip(... 'override is on the default variant') and would have gone silently dormant once the override became the default. Rewrote both to compare the default variant against the first variant that differs, so they assert the toggle in either direction. Verified: scripts/validate_registry.py OK, 35 python tests, 26 playwright tests, 0 skipped. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
WalkthroughThe M-1 firmware registry and migration documentation now present WLED 16.0.1 as the default option, while installer tests resolve release-note repositories and classic-installer visibility from the selected variant. ChangesM-1 firmware variants
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The M-1 page opened on WLED-MM 14.5.1 (Rev6). Make WLED 16.0.1 (Rev6 only)
the default by moving it to the first key of firmware.stable, which is what
device.js picks on load.
Rev4 hardware is not covered by 16.0.1, so Rev4 owners now have to switch to
the "WLED-MM 14.5.1 (Rev4)" variant instead of landing on a working default.
Side effect of the reorder, both already-built behavior, no code change: the
page now loads with the "Classic installer" link hidden (WLED-M1 has no
installer page, installers.stable maps that variant to null) and the header
GitHub link pointing at WLED-M1. Both come back on a 14.5.1 variant.
Two tests guarded themselves with test.skip(... 'override is on the default
variant') and would have gone silently dormant once the override became the
default. Rewrote both to compare the default variant against the first variant
that differs, so they assert the toggle in either direction.
Verified: scripts/validate_registry.py OK, 35 python tests, 26 playwright
tests, 0 skipped.
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation