Skip to content

Fix the WizMote Ethernet pairing note and drop em dashes - #1066

Merged
bharvey88 merged 1 commit into
devfrom
fix/cast1-wizmote-timing
Aug 1, 2026
Merged

Fix the WizMote Ethernet pairing note and drop em dashes#1066
bharvey88 merged 1 commit into
devfrom
fix/cast1-wizmote-timing

Conversation

@bharvey88

@bharvey88 bharvey88 commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

The WizMote page said pairing on the Ethernet firmware waits 30 seconds on each radio channel and to allow a few minutes. That misreads the firmware.

In CAST-1_ETH.yaml the scan interval is 2 seconds, and the 30000 ms check is an idle threshold, not a per-channel dwell:

interval:
  - interval: 2s
    ...
    return want && (millis() - id(wizmote_last_packet_ms) > 30000);

wizmote_last_packet_ms is only assigned after the early return that rejects any MAC that isn't already paired, so during pairing it never updates. The device hops channels every couple of seconds and sweeps all 13 in well under a minute.

Telling someone to wait a few minutes hides a real pairing failure behind expected behavior.

Also replaces the five em dash placeholders in the Sensor Definitions configuration table with n/a.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated CAST-1 Ethernet firmware pairing guidance to reflect faster channel cycling and typical pairing within one minute.
    • Clarified unavailable configuration settings by replacing dash placeholders with “n/a” in sensor setup documentation.

The pairing note said the CAST-1 waits 30 seconds on each radio channel,
which misread the firmware. In CAST-1_ETH.yaml the scan interval runs
every 2 seconds, and the 30000 ms check is an idle threshold, not a per
channel dwell. wizmote_last_packet_ms is only set for an already paired
MAC, so during pairing it never updates and the device hops channels
every couple of seconds, sweeping all 13 in well under a minute.

Telling someone to wait a few minutes hides a genuine pairing failure.

Also replaces the em dash placeholders in the Sensor Definitions
configuration table with n/a.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@bharvey88
bharvey88 merged commit 5aaf641 into dev Aug 1, 2026
1 check was pending
@bharvey88
bharvey88 deleted the fix/cast1-wizmote-timing branch August 1, 2026 00:55
@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1528e66d-6bc5-42b6-b995-e4400755746c

📥 Commits

Reviewing files that changed from the base of the PR and between 6b1b0db and f19eed5.

📒 Files selected for processing (2)
  • docs/products/cast1/examples/wizmote-blueprint.md
  • docs/products/cast1/setup/sensor-definitions.md

Walkthrough

The CAST-1 documentation now describes updated Ethernet pairing timing and uses n/a for configuration settings without values.

Changes

CAST-1 Documentation

Layer / File(s) Summary
Ethernet pairing guidance
docs/products/cast1/examples/wizmote-blueprint.md
The pairing note describes channel scanning every few seconds and pairing within about one minute while a button is pressed.
Configuration placeholders
docs/products/cast1/setup/sensor-definitions.md
Entries without values use n/a for firmware, WizMote, reboot, and factory-reset settings.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Poem

A bunny reads the pairing guide,
“Press the button,” it hops beside.
Channels scan, the link is near,
n/a makes blank fields clear.
CAST-1 docs now shine bright!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/cast1-wizmote-timing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant