Skip to content

Keep Bluetooth Proxy on for legacy BLE builds - #108

Open
bharvey88 wants to merge 1 commit into
betafrom
fix/ble-proxy-restore-on
Open

Keep Bluetooth Proxy on for legacy BLE builds#108
bharvey88 wants to merge 1 commit into
betafrom
fix/ble-proxy-restore-on

Conversation

@bharvey88

@bharvey88 bharvey88 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Version: 26.7.29.1

What does this implement/fix?

The Bluetooth Proxy switch does restore from flash, but the _OFF half of
RESTORE_DEFAULT_OFF only decides the boot where nothing is stored yet, which is
the first boot after the switch shipped. MSR-1_BLE.yaml inherited that mode from
Core, so a legacy BLE device that had always proxied comes up with the proxy off
after updating and stays that way until the user finds the switch. Reported in ApolloAutomation/MSR-2#92.

Core now reads the mode from a bluetooth_proxy_restore_mode substitution
defaulting to RESTORE_DEFAULT_OFF, and MSR-1_BLE.yaml overrides it to
RESTORE_DEFAULT_ON, the same override pattern that file already uses for its OTA
manifest URLs. The unified image is unchanged, and a user's saved choice still wins
on every later boot.

Validated with esphome config on 2026.7.2 across MSR-1.yaml, MSR-1_BLE.yaml
and MSR-1_Factory.yaml. Rendered switch: standard RESTORE_DEFAULT_OFF, BLE
RESTORE_DEFAULT_ON.

Matching PRs go to AIR-1, MSR-2 and MTR-1, which carry the identical switch and BLE variant.

Types of changes

  • Bugfix (fixed change that fixes an issue)
  • New feature (thanks!)
  • Breaking change (repair/feature that breaks existing functionality)
  • Dependency Update - Does not publish
  • Other - Does not publish
  • Website of github readme file update - Does not publish
  • Github workflows - Does not publish

Checklist / Checklijst:

  • The code change has been tested and works locally
  • The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

  • Added/updated documentation for the web page

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Added configurable Bluetooth Proxy restoration behavior.
    • Bluetooth Proxy can now automatically restore its previous or configured state after first boot, factory reset, or updates.
    • Legacy BLE device support remains enabled by default on MSR-1 devices during updates.
  • Bug Fixes
    • BLE scanning now follows the restored Bluetooth Proxy state, improving consistency after restart or reset.

The Bluetooth Proxy switch does restore from flash, but the _OFF half of
RESTORE_DEFAULT_OFF decides the boot where nothing is stored yet, which is
the first boot after the switch shipped. MSR-1_BLE.yaml inherited that mode
from Core, so legacy BLE devices that had always proxied came up with the
proxy off after updating.

Core now reads the mode from a bluetooth_proxy_restore_mode substitution
defaulting to RESTORE_DEFAULT_OFF, and MSR-1_BLE.yaml overrides it to
RESTORE_DEFAULT_ON, the same override pattern the file already uses for its
OTA manifest URLs. The unified image is unchanged and a user's saved choice
still wins on every later boot.

Refs ApolloAutomation/MSR-2#92

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: af017a80-b3fb-4084-8fab-f1c3bda65ab8

📥 Commits

Reviewing files that changed from the base of the PR and between 0b69a22 and 388de43.

📒 Files selected for processing (2)
  • Integrations/ESPHome/Core.yaml
  • Integrations/ESPHome/MSR-1_BLE.yaml

Walkthrough

The ESPHome core configuration now exposes Bluetooth Proxy restore behavior as a substitution, defaults it off, and applies it to the proxy switch. The MSR-1 BLE configuration overrides the setting to restore on, and the core version is updated.

Changes

Bluetooth Proxy restore configuration

Layer / File(s) Summary
Core restore-mode wiring
Integrations/ESPHome/Core.yaml
Updates the version, defines the default Bluetooth Proxy restore mode, updates the boot comment, and applies the substitution to the proxy switch.
BLE restore override
Integrations/ESPHome/MSR-1_BLE.yaml
Sets Bluetooth Proxy restoration to RESTORE_DEFAULT_ON for the BLE variant.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

Poem

A bunny found a switch at dawn,
Restored its state and carried on.
Core keeps off by default in sight,
BLE wakes proxy on just right.
Fresh YAML hops into the light!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: keeping Bluetooth Proxy enabled by default for legacy BLE builds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ble-proxy-restore-on

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant