Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix missing integrity attributes on CDN assets - #68

Closed
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
sentinel-fix-cdn-integrity-4451816026561212263
Closed

google-labs-jules[bot] wants to merge 1 commit into
mainfrom
sentinel-fix-cdn-integrity-4451816026561212263

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Third-party assets (KaTeX CSS and JS) were loaded from a public CDN (jsDelivr) without integrity attributes. This poses a supply chain risk (XSS/defacement) if the CDN is compromised and serves a malicious script, as the browser would execute it trustingly.
🎯 Impact: If exploited, attackers could inject malicious JavaScript to steal sessions, redirect users, or deface the application.
πŸ”§ Fix: Added Subresource Integrity (SRI) integrity attributes with SHA-384 hashes for all external KaTeX resources in web/index.html. This ensures the browser only executes the scripts if their cryptographic hash matches the expected value. The required crossorigin="anonymous" attribute was properly maintained.
βœ… Verification: Verify that the application continues to load correctly and that cargo check and cargo test pass successfully. In the browser network tab, you can inspect the resources to ensure they are fetched with the specified integrity constraint.


PR created automatically by Jules for task 4451816026561212263 started by @panayang

@google-labs-jules

Copy link
Copy Markdown
Contributor Author

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cn-starlabs

Copy link
Copy Markdown
Member

review locally and close this PR

@panayang
panayang deleted the sentinel-fix-cdn-integrity-4451816026561212263 branch October 26, 2026 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant