Repository navigation
π‘οΈ Sentinel: [HIGH] Fix missing integrity attributes on CDN assets - #68
google-labs-jules[bot] wants to merge 1 commit into
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
review locally and close this PR |
π¨ Severity: HIGH
π‘ Vulnerability: Third-party assets (KaTeX CSS and JS) were loaded from a public CDN (jsDelivr) without
integrityattributes. This poses a supply chain risk (XSS/defacement) if the CDN is compromised and serves a malicious script, as the browser would execute it trustingly.π― Impact: If exploited, attackers could inject malicious JavaScript to steal sessions, redirect users, or deface the application.
π§ Fix: Added Subresource Integrity (SRI)
integrityattributes with SHA-384 hashes for all external KaTeX resources inweb/index.html. This ensures the browser only executes the scripts if their cryptographic hash matches the expected value. The requiredcrossorigin="anonymous"attribute was properly maintained.β Verification: Verify that the application continues to load correctly and that
cargo checkandcargo testpass successfully. In the browser network tab, you can inspect the resources to ensure they are fetched with the specified integrity constraint.PR created automatically by Jules for task 4451816026561212263 started by @panayang