Skip to content

Fix MacOS builds #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AphelionWasTaken merged 1 commit into from
Apr 21, 2026
Merged

Fix MacOS builds #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,12 +103,10 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
tag_name: v2.3.0
release_name: v2.3.0
tag_name: v2.3.1
release_name: v2.3.1
body: |
Allows window to be expanded vertically to show more results at once. Fixes threading issue while performing large searches.

Also generally speeds things up a bit when performing large searches, such as games.yml parsing.
Set the icon to only be referenced on Windows, fixing MacOS builds until an icon is added for MacOS.
draft: false
prerelease: false

Expand Down
9 changes: 6 additions & 3 deletions PySN.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@ def __init__(self, *args, **kwargs):
self.grid_rowconfigure((0, 1, 2, 3, 4), weight=1)
self.grid_columnconfigure((0, 1, 2, 3, 4, 5), weight=1)
self.temp_save, self.temp_rpcs3 = ConfigSettings.check_config()
self.after(200, lambda: self.iconbitmap(resource_path("AphIcon.ico")))
if sys.platform == 'win32':
self.after(200, lambda: self.iconbitmap(resource_path("AphIcon.ico")))

self.save_dir_label = customtkinter.CTkLabel(master=self, text='Download Update PKGs To This Folder:',justify = 'center', anchor='center')
self.save_dir_label.grid(row=0, column=1, columnspan=4, padx=5, pady=(20,0), sticky='sew')
Expand Down Expand Up @@ -189,7 +190,8 @@ def __init__(self, *args, **kwargs):
self.geometry('400x240')
self.grid_rowconfigure((0, 1, 2, 3, 4), weight=1)
self.grid_columnconfigure((0, 1, 2, 3, 4, 5), weight=1)
self.after(200, lambda: self.iconbitmap(resource_path("AphIcon.ico")))
if sys.platform == 'win32':
self.after(200, lambda: self.iconbitmap(resource_path("AphIcon.ico")))

self.save_dir_label = customtkinter.CTkLabel(master=self, text='You are about to download all of the updates in the list!\n\n\nContinue?\n', anchor='center')
self.save_dir_label.grid(row=1, column=2, columnspan=2, padx=20, pady=0, sticky='ew')
Expand Down Expand Up @@ -306,7 +308,8 @@ def __init__(self):
self.grid_rowconfigure((1), weight=1)
self.grid_columnconfigure((0, 1, 2, 3, 4), weight=1)
self.bind('<Return>', lambda event: self.button_search())
self.iconbitmap(resource_path("AphIcon.ico"))
if sys.platform == 'win32':
self.iconbitmap(resource_path("AphIcon.ico"))

self.entry = customtkinter.CTkEntry(master=self, placeholder_text='Enter Serial', width = 125)
self.entry.grid(row=0, column=0, padx=(4,2), pady=(6,0), sticky='ew')
Expand Down
Loading