test: cover geth fixture cleanup on errors#3851
Open
vuyua9 wants to merge 1 commit into
Open
Conversation
165f155 to
0b94e82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
start_geth_process_and_yield_portnow uses afinallyblock to stop the geth process when a test fails after the fixture yields, but that cleanup path was not covered by a focused regression test.Related to the go-ethereum integration test fixture cleanup path.
How was it fixed?
Added a small test that drives the fixture generator directly with monkeypatched geth process helpers. The test throws a consumer exception into the generator and asserts that:
kill_proc_gracefully()is calledproc.communicate(timeout=5)is calledcommunicate()is invokedTodo:
newsfragments/3851.internal.rstTests
git diff --check.venv/bin/python -m pytest tests/integration/go_ethereum/test_conftest_cleanup.py -qNote:
uv pip install -e '.[test]'hit a localsafe-pysha3build issue in this macOS CommandLineTools environment, so I installed the package plus the focused dependencies needed for this test and ran the targeted pytest above.Cute Animal Picture