fix: expose AsyncIPCProvider on AsyncWeb3#3848
Open
suyua9 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AsyncIPCProvideronAsyncWeb3, matching the other async provider convenience attributesRationale
AsyncIPCProvideris already exported from the package root, and the docs include examples that useAsyncWeb3.AsyncIPCProvider(...). UnlikeAsyncHTTPProvider,WebSocketProvider, andAsyncEthereumTesterProvider, theAsyncWeb3class did not expose this provider attribute, so those examples would fail at the symbol lookup step.Testing
.venv/bin/python -m pytest tests/core/providers/test_provider_init.py -q -k 'async_web3_exposes_async_ipc_provider'python3 -m py_compile web3/main.py tests/core/providers/test_provider_init.pygit diff --checkNote: running the full
tests/core/providers/test_provider_init.pyfile in this local lightweight venv failed only for the existing EthereumTester provider parametrizations becauseeth_testerwas not installed. The new focused regression test passed.