fix: preserve sync RPC empty params shape#3847
Open
luyua9 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Follow-up to #3823 / #3825.
#3825 fixed the async persistent-provider path by replacing
params or []with[] if params is None else params, preserving empty tuple/dict params for cache-key consistency.The sync
JSONBaseProvider.encode_rpc_request()path still usedparams or [], so an empty named-params payload ({}) was serialized as positional params ([]). That changes JSON-RPC request shape before the request is sent.How was it fixed?
Noneto[].Noneon sync encoding.Validation
git diff --checkpython -m pytest -q tests/core/caching-utils/test_request_caching.py -k 'sync_encode_rpc_request_preserves_params_shape or async_form_request_preserves_params_shape'could not run in this local checkout becausecached_propertyis not installed in the environment (ModuleNotFoundError).