improve(contract): clearer error messages during call() #1002#3846
Open
dpk-jr wants to merge 1 commit into
Open
improve(contract): clearer error messages during call() #1002#3846dpk-jr wants to merge 1 commit into
dpk-jr wants to merge 1 commit into
Conversation
Add better error handling for contract revert/panic errors: - Decode Error(string) reverts and show human-readable message - Decode Panic(uint256) errors with specific panic code meanings - Handle unknown custom errors with selector in message - Provide clearer error messages instead of cryptic eth-abi exceptions Fixes ApeWorX#1002
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve error messages when contract calls fail during
call()operations.Changes
_decode_contract_error()function to decode revert/panic errorsError(string)reverts - shows human-readable messagePanic(uint256)errors - shows specific panic code meaningBefore (cryptic error)
Could not decode contract function call to mint with return data: 0x08c379a0...
After (clear error)
execution reverted: Not enough ETH
or
execution reverted: Panic(Arithmetic overflow/underflow)
Related Issue
Fixes #1002